Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Select label #177

Merged
merged 10 commits into from
Oct 13, 2023
Merged

Adds Select label #177

merged 10 commits into from
Oct 13, 2023

Conversation

saurabhsutar192
Copy link
Contributor

Adds Select label

Description

Added Select Label Support and changed the handling of icon clicks which fixes a bug when the component is in clearable mode the dropdown won't open on clicking the icon

Motivation and Context

No label and fixes the above mentioned bug

How Has This Been Tested?

Local build success and manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit cefd896
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6527b83e0aa592000820d573
😎 Deploy Preview https://deploy-preview-177--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saurabhsutar192 saurabhsutar192 added the enhancement New feature or request label Mar 31, 2023
Copy link
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raalzz Raalzz merged commit 27a076a into main Oct 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants